-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cleanup testConfig.baseRoute
and use testConfig.previewBase
#14475
test: cleanup testConfig.baseRoute
and use testConfig.previewBase
#14475
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm somewhat leaning to the approach we have before, maybe renaming as testConfig.previewBase
would make more sense? The custom plugin to set the base only for preview is a bit complex to setup.
There was a problem with the previous |
Yeah if #12298 is merged first to simplify the changes, then I'd be fine with it 👍 |
testConfig.baseRoute
testConfig.baseRoute
and use testConfig.previewBase
Renamed to |
testConfig: { | ||
baseRoute: '/url-base/', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not using relative path, so this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for making the changes
Description
testConfig.baseRoute
as it was not usedtestConfig.baseRoute
was introduced to do this. So I restored that by changing the base when running preview.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).