feat: allow disabling ws server completely if hmr: false

[danielroe]

Vite exposes the option of disabling HMR completely. I'd welcome a contrary opinion, but there seems to be no reason to start a WS server in this case, and there are reasons why users might want to have it disabled.

In this instance we might also consider not attempting a connection in packages/vite/src/client/client.ts either, or disabling the client completely.

[thebrownfox]

@danielroe is this condition right?
c6b84a8#diff-abb3345b6e3b2ec6d297c2ebc54cca85ae4487a31bac3cc9e78457f5114adb26R273

[thebrownfox]

@danielroe happens 🙈 I was just curious and it struck me why would you want to do the opposite 😅

[thebrownfox]

@danielroe sorry to bother but this should solve the issue (nuxt/vite#70), right? When do you think it could be released? I'd love to use vite in this particular project.

[antfu]

As mentioned in the comments. Marked as changed requested for tracking

[danielroe]

Apologies for the delay. An initial mock implementation done. Very happy for changes to be made 👍

[antfu]

From our last meeting with Evan, our concern is that the Websocket Server is not only for HMR but also for page reloading or plugins. And it's not very clear why you want to disable this completely, can you provide more context? Thanks

[thebrownfox]

From our last meeting with Evan, our concern is that the Websocket Server is not only for HMR but also for page reloading or plugins. And it's not very clear why you want to disable this completely, can you provide more context? Thanks

In my case I need sometimes to see what's going on on dev/staging server, thus I need dev environment. It's possible to set it up in plain vue, but impossible in nuxt -> I need to startup dev server but without all of the HMR as nothing changes on file system. I tried to configure reverse proxy to work with the websocket, but without any success so far.

[patak-dev]

@danielroe is this feat still needed? Maybe we should close this one if it isnt longer blocking you

[Enteleform]

@danielroe is this feat still needed? Maybe we should close this one if it isnt longer blocking you

I think there might be other issues that could be resolved by this?

• codesandbox HMR broken nuxt/vite#47
• Not possible to disable HMR nuxt/vite#70

Not 100% sure that they're related, but I found this PR referenced while investigating the CodeSandbox issue (which also happens with Vue, not just Nuxt).

[patak-dev]

Closing this one, IIUC, this isn't an issue for Nuxt at this point. @danielroe would you open an issue to keep discussing the use cases for something like this if it is still required?

[hxlniada]

why close this.

[Plasma]

I've encountered wanting to disable this during development because we don't use have a SPA app that we want reloading, instead we will just reload the page as needed. While hmr: false is set, we still receive a websocket error in console during development, would be great if this could be re-visited, thank you.

[bluwy]

#6315 has more info on how the ws server is still needed.

[JadenH]

I've also run into the same use case where I can't have a websocket connection. Totally cool with a separate config as I can see how it's confusing to tie the websocket functionality to hmr when the websocket is used for other things.

I'd like to propose something like this:

...
server: {
  ws: false
}
...