Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix node memory issues #3054

Merged
merged 3 commits into from
Apr 19, 2021
Merged

chore(ci): fix node memory issues #3054

merged 3 commits into from
Apr 19, 2021

Conversation

nihalgonsalves
Copy link
Member

@nihalgonsalves nihalgonsalves commented Apr 19, 2021

Description

Set --max-old-space-size to attempt to fix memory issues

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-requested a review April 19, 2021 19:05
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Apr 19, 2021
@Shinigami92
Copy link
Member

[ci skip]

Co-authored-by: Shinigami <chrissi92@hotmail.de>
@nihalgonsalves nihalgonsalves marked this pull request as ready for review April 19, 2021 19:12
@Shinigami92
Copy link
Member

🤔 Seems that env is always passed to every step
Should we only pass it to the test steps? Or just anytime?

@nihalgonsalves
Copy link
Member Author

@Shinigami92 I don't see the harm in always setting it as default.

@nihalgonsalves
Copy link
Member Author

@Shinigami92 I committed the comment change as [ci skip], thus the pending check.. re-run or just merge?

@Shinigami92
Copy link
Member

@Shinigami92 I committed the comment change as [ci skip], thus the pending check.. re-run or just merge?

Just re-run
That way we also see (a little bit randomly) if it works or not ^^

@nihalgonsalves
Copy link
Member Author

Looks good!

@patak-dev patak-dev merged commit 1f8be5a into vitejs:main Apr 19, 2021
@nihalgonsalves nihalgonsalves deleted the patch-2 branch April 19, 2021 19:36
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants