Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: files instead of .npmignore for better readability #3694

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Jun 7, 2021

Description

See discussions at #3656 (comment)

This PR achieves the same functionality as #3656, but uses fewer negated glob patterns.

Additional context

Output of npm pack before and after this PR:
https://www.diffchecker.com/8e5xXXjV


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@nihalgonsalves nihalgonsalves added the p1-chore Doesn't change code behavior (priority) label Jun 7, 2021
@patak-dev patak-dev changed the title refactor: use files instead of .npmignore for better readability chore: files instead of .npmignore for better readability Jun 8, 2021
@patak-dev patak-dev merged commit f525a36 into vitejs:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants