-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow use of clientPort without middlewareMode #4332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
feat: hmr
p2-nice-to-have
Not breaking anything but nice to have (priority)
labels
Jul 20, 2021
If someone needs this fixed, feel free to use patch-package with the following patch:
|
@Cretezy this PR will need to be rebased |
Awesome, thanks @Cretezy |
@benmccann PR has been updated! |
patak-dev
changed the title
Allow use of clientPort without middlewareMode
feat: allow use of clientPort without middlewareMode
Aug 26, 2021
Shinigami92
approved these changes
Aug 26, 2021
yyx990803
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #3737. Currently,
clientPort
is ignore when not in middleware mode.Currently, it's impossible to run in normal mode behind a proxy due to the WebSocket connecting to the wrong port (#2474).
This can't be bypassed by disabling HMR (my preferred solution) because disabling HMR still keeps the WebSocket connection.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).