Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): template src isn't working when script setup #5418

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Oct 25, 2021

Description

fix #5324

Additional context

The inlineTemplate option of compile script is not based on the actual situation of template

inlineTemplate: !options.devServer,

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 25, 2021
@y1d7ng y1d7ng requested a review from Shinigami92 October 26, 2021 02:02
@antfu antfu merged commit 518da44 into vitejs:main Nov 2, 2021
@y1d7ng y1d7ng deleted the setup-import-template branch November 2, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue template src is not working in vite build&serve
3 participants