-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warn for unresolved css in html #7911
Conversation
styleUrls.push({ | ||
url, | ||
start: node.loc.start.offset, | ||
end: node.loc.end.offset | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still unsure about the order change in the JS that this is going to produce. IIUC, before if the user had first the CSS styles, these were the first imports in the JS, and now they will be imported at the end after all other JS tags. I wonder if we should mark the JS position by adding something like
js += `${STYLE_IMPORT_MARKER_}${styleUrlId}`
And then we can replace it by \nimport ...
or by `` depending on the result of the URL resolution.
Co-authored-by: patak <matias.capeletto@gmail.com>
Description
fix: #7160
Additional context
catch unresolved css url in html.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).