Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): include Safari 12 to baseline #9190

Closed
wants to merge 1 commit into from

Conversation

Amareis
Copy link

@Amareis Amareis commented Jul 18, 2022

Description

By given links to caniuse, safari 12 is included in modern baseline, as it supports all needed ESM features.

It matters for me, because safari 12 is the last available browser on old iPhones, which is pinned to ios 12 (like iPhone 6+, which is our work device for checking bottom end devices).

So it's even not needed to use legacy build for it, and so it should be fixed in docs.

If there is some another reasons to starts official support with Safari 13, they really should be covered in docs.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy
Copy link
Member

bluwy commented Jul 20, 2022

Safari 13 is explicitly specified here. While is may still work in Safari 12 (judging from this table there isn't much difference), we don't guarantee it'll work in Safari 12, hence I don't think the docs should reflect that.

@Amareis
Copy link
Author

Amareis commented Jul 21, 2022

Safari 13 is explicitly specified here

Yep, i saw it after making PR. That's pretty strange, because browserslist query specified in comment includes ios safari 12 (and don't includes safari 13, because safari 12 is last browser available on iPhone 5s-6+, and all newer devices supports iOS 15).

> npx browserslist "defaults and supports es6-module and supports es6-module-dynamic-import"
and_chr 103
and_ff 101
and_qq 10.4
android 103
chrome 103
chrome 102
chrome 101
edge 103
edge 102
firefox 102
firefox 101
firefox 91
ios_saf 15.5
ios_saf 15.4
ios_saf 15.2-15.3
ios_saf 14.5-14.8
ios_saf 14.0-14.4
ios_saf 12.2-12.5 (!!!)
op_mob 64
opera 87
opera 86
opera 85
safari 15.5
safari 15.4
samsung 17.0
samsung 16.0

And all is working pretty fine on it, with some polyfills and adjusted syntax transpiling (nullish coalescing and optional chaining not working here). So, maybe it worth to support it... But it should be discussed in separate issue, i think.

@bluwy
Copy link
Member

bluwy commented Jul 21, 2022

There's already a PR that proposes to upgrade to safari 14 instead 😄. We shouldn't be decreasing the baseline because of the ESM features listed in the docs only. We're following browser usage on caniuse, and increasing it in each major so we can do less work in transpiling in dev. For builds, you can set build.target to something lower if it's a concern, but the default browsers apply the usual evergreen browsers only.

I'll close this as we don't guarantee safari 12 to be working.

@bluwy bluwy closed this Jul 21, 2022
@Amareis
Copy link
Author

Amareis commented Jul 22, 2022

For builds, you can set build.target to something lower if it's a concern, but the default browsers apply the usual evergreen browsers only.

Yep, and it works perfectly, but vite/client isn't working because of optional chaining syntax -_-

@bluwy bluwy mentioned this pull request Jul 23, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants