Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update tsconfig.json error #9409 #9412

Closed
wants to merge 1 commit into from
Closed

fix: update tsconfig.json error #9409 #9412

wants to merge 1 commit into from

Conversation

caoxiemeihao
Copy link
Contributor

@caoxiemeihao caoxiemeihao commented Jul 28, 2022 •
edited by bluwy
Loading

Description

Error while tsconfig.json hot update #9409

fix #9409

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

This was referenced Jul 28, 2022
Closed
Closed
@bluwy
Copy link
Member

bluwy commented Aug 21, 2022

This change make sense to me, and it's better in the long run to avoid the singleton. It looks like the tests are failing though.

@bluwy bluwy added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Aug 21, 2022
@caoxiemeihao
Copy link
Contributor Author

Fixed by #11747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while tsconfig.json hot update
2 participants
@caoxiemeihao @bluwy