Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Deprecate ExecuteBatch calls on autocommit mode in VTGate #6407

Closed
harshit-gangal opened this issue Jul 3, 2020 · 0 comments · Fixed by #6431
Closed

RFC: Deprecate ExecuteBatch calls on autocommit mode in VTGate #6407

harshit-gangal opened this issue Jul 3, 2020 · 0 comments · Fixed by #6431
Milestone
v7.0

Comments

@harshit-gangal
Copy link
Member

VTGate currently calls ExecuteBatch when autocommit is true this was due to the reason that earlier VTTablet Execute always create a transaction even on autocommit true.
Now, the underlying VTTablet Execute can handle autocommit mode and therefore it is safe to switch the call from ExecuteBatch to Execute.
This also simplifies the VTGate execution code path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging a pull request may close this issue.

Replace ExecuteBatch call with Execute in VTGate planetscale/vitess
1 participant
@harshit-gangal