Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Remove deprecated RPCs and vtctl commands #7109

Closed
deepthi opened this issue Dec 4, 2020 · 2 comments · Fixed by #7115
Closed

Task: Remove deprecated RPCs and vtctl commands #7109

deepthi opened this issue Dec 4, 2020 · 2 comments · Fixed by #7115
Assignees
Milestone

Comments

@deepthi
Copy link
Member

deepthi commented Dec 4, 2020

In 7.0, we deprecated the following RPCs and vtctl commands. They should now be deleted.

vtctl commands:
StopSlave
StartSlave
ChangeSlaveType

vttablet RPCs:
InitSlave
SlaveStatus
StopSlave
StopSlaveMinimum
StartSlave
StartSlaveUntilAfter
GetSlaves
SlaveWasPromoted
SlaveWasRestarted

Also delete the Request and Response protobufs associated with these RPCs.

@derekperkins
Copy link
Member

Not sure if the timelines line up, but we could potentially save some work by prioritizing the new vtctld interface and just removing these commands altogether rather than changing them. #7058

@deepthi
Copy link
Member Author

deepthi commented Dec 4, 2020

These RPCs and commands have already been deprecated so we will delete them.
But we might be able to change how we accomplish #7114. If the vtctl commands anyways call the new vtctld RPCs we might be able to do what you are suggesting and delete some of the RPCs right away instead of deprecating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants