Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin implementation for CREATE and DROP DATABASE #7525

Closed
deepthi opened this issue Feb 20, 2021 · 2 comments · Fixed by #7381
Closed

Allow plugin implementation for CREATE and DROP DATABASE #7525

deepthi opened this issue Feb 20, 2021 · 2 comments · Fixed by #7381

Comments

@deepthi
Copy link
Member

deepthi commented Feb 20, 2021

Feature Description

We should add support for plugin implementations of CREATE DATABASE and DROP DATABASE.

  • The default plugin will return an error (NOT_ALLOWED or something like that).
  • For CREATE, if database (keyspace) already exists we return an error, otherwise we call the plugin.
  • For DROP, if database (keyspace) does NOT exist, we return an error, otherwise we call the plugin.

Use Case(s)

Frameworks like Rails create temporary databases for running test suites.

@systay
Copy link
Collaborator

systay commented Feb 22, 2021

The default plugin should return a failure, not be a no-op, right?

@deepthi
Copy link
Member Author

deepthi commented Feb 22, 2021

The default plugin should return a failure, not be a no-op, right?

Good point. I will edit the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants