Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vttestserver: default charset #7942

Closed
deepthi opened this issue Apr 23, 2021 · 2 comments
Closed

vttestserver: default charset #7942

deepthi opened this issue Apr 23, 2021 · 2 comments
Assignees
@harshit-gangal
Labels
Component: Query Serving

Comments

@deepthi
Copy link
Member

deepthi commented Apr 23, 2021 •
edited
Loading

Feature Description

vttestserver defaults the charset to utf8. Either we should change this to utf8mb4 or provide a way to override it on the docker container (or both).
https://github.com/vitessio/vitess/blob/master/go/vt/vttest/vtprocess.go#L179

Use Case(s)

Frameworks set charset. This is required to automate testing.
@harshit-gangal
Copy link
Member

I am of the opinion that we make it as default on vttablet.

@mcronce mcronce mentioned this issue Apr 27, 2021
Merged
2 tasks
@deepthi deepthi mentioned this issue Apr 27, 2021
Open
@deepthi
Copy link
Member Author

deepthi commented May 25, 2021

Fixed in #7970

@deepthi deepthi closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshit-gangal harshit-gangal

Labels
Component: Query Serving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepthi @askdba @harshit-gangal