Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: change vtctld's realtime_status to use new health check #9358

Closed
deepthi opened this issue Dec 10, 2021 · 0 comments · Fixed by #10254
Closed

Task: change vtctld's realtime_status to use new health check #9358

deepthi opened this issue Dec 10, 2021 · 0 comments · Fixed by #10254

Comments

@deepthi
Copy link
Member

deepthi commented Dec 10, 2021

vtctld has a reference to the old (Legacy) health check implementation.

vitess/go/vt/vtctld/realtime_status.go

Line 37 in 4995054

hc := discovery.NewLegacyHealthCheck(*vtctl.HealthcheckRetryDelay, *vtctl.HealthCheckTimeout)

We need to move to this to the new one so that we can delete the old one completely.

This blocks #9218.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the HealthCheckImpl in vtctld instead of the LegacyHealthCheck planetscale/vitess
1 participant
@deepthi