Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Vitess buffering implementation #9359

Closed
FancyFane opened this issue Dec 11, 2021 · 0 comments · Fixed by #9360
Closed

Change default Vitess buffering implementation #9359

FancyFane opened this issue Dec 11, 2021 · 0 comments · Fixed by #9360
Milestone
v13.0

Comments

@FancyFane
Copy link
Collaborator

Feature Description

The current default buffering implementation leads to inconsistent behavior as seen in github issues #9356 and #9346. We may want to change the default buffering implementation to use keyspace events which appears to be more reliable. Currently, this has to be set manually using the flag -buffer_implementation=keyspace_events.
@mattlord mattlord assigned mattlord and unassigned mattlord Dec 11, 2021
@mattlord mattlord added this to the v13.0 milestone Dec 11, 2021
This was referenced Dec 11, 2021
Merged
Closed
vmg pushed a commit to planetscale/vitess that referenced this issue Dec 15, 2021
@FancyFane @vmg
Change default buffer implementation vitessio#9359
77f7ca3 
Signed-off-by: FancyFane <fane@planetscale.com>
@vmg vmg closed this as completed in #9360 Dec 15, 2021
vmg added a commit that referenced this issue Dec 15, 2021
@vmg
Merge pull request #9360 from planetscale/fane-9359-buffer-default
4a2e63a 
Change default buffer implementation #9359
@FancyFane FancyFane mentioned this issue Dec 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v13.0
Development

Successfully merging a pull request may close this issue.

Change default buffer implementation #9359 planetscale/vitess
2 participants
@mattlord @FancyFane