Update the embedded config data in mysqlctl #10094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mattlord
added
Component: General
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
from
c842011
to
9395e13
Compare
3 tasks
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
21 times, most recently
from
9823bcd
to
dd0ecf9
Compare
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
from
dd0ecf9
to
5a893b9
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
from
5a893b9
to
a03de1f
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
3 times, most recently
from
0c132a2
to
39db12d
Compare
Restore test files Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
update_mysqlctl_ricebox
branch
from
39db12d
to
ec030ae
Compare
mattlord
added a commit
to planetscale/vitess
that referenced
this pull request
May 24, 2022
This ended up causing various failures when that change was applied in mysqlctl by updating its rice box (make embed_config). You can see this in: vitessio#10094 We're instead going to schedule work to add full super_read_only support to Vitess in: vitessio#10363 Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
mattlord
added a commit
that referenced
this pull request
May 25, 2022
* Revert super_read_only config file changes This ended up causing various failures when that change was applied in mysqlctl by updating its rice box (make embed_config). You can see this in: #10094 We're instead going to schedule work to add full super_read_only support to Vitess in: #10363 * Remove MySQL 5.6 config This is a follow-up to #10295
3 tasks
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I will need to rebase this on main after #10080 is resolved and merged as that also makes some changes to the config files that get embedded. But the bulk of the work in this PR is about getting everything to work once
super_read_onlyis actually applied.Related Issue(s)
Checklist
Deployment Notes