-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test to confirm that the mysqlctl rice box is current #10182
Merged
rohit-nayak-ps
merged 4 commits into
vitessio:main
from
planetscale:rn-rice-box-unit-test
Jun 1, 2022
Merged
Unit test to confirm that the mysqlctl rice box is current #10182
rohit-nayak-ps
merged 4 commits into
vitessio:main
from
planetscale:rn-rice-box-unit-test
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Build/CI
release notes none
labels
Apr 30, 2022
Related to this: #10094 |
This was referenced May 21, 2022
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-rice-box-unit-test
branch
from
May 27, 2022 07:36
d019daa
to
0e3cc8e
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mattlord
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like it ❤️
deepthi
approved these changes
May 28, 2022
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently had an issue where the
init_db.sql
has been updated but the corresponding rice box was not updated. (rice box reference: https://github.com/GeertJohan/go.rice)All files in the config directory are part of this rice box. This PR adds a unit test to compare these files on disk with that embedded in the rice box.
The other rice-box usage is around the old vtctld UI and embedded vitess binaries, those are not tested for.