Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to MySQL and Percona 5.6 #10295

Merged
merged 1 commit into from
May 24, 2022
Merged

remove references to MySQL and Percona 5.6 #10295

merged 1 commit into from
May 24, 2022

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented May 13, 2022 •
edited by mattlord
Loading

Description

MySQL 5.6 has been EOL for some time now.
Docker builds no longer work, so they have been disabled.
This PR removes the docker files for MySQL 5.6 and Persona 5.6, and references to them in various bootstrap / build files.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@deepthi
remove references to MySQL and Percona 5.6
d672b63 
Signed-off-by: deepthi <deepthi@planetscale.com>
@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@deepthi
Copy link
Member Author

deepthi commented May 13, 2022

I have NOT removed the mysql56.cnf file. Removing that should be followed by make embed_config, which needs to wait until we are able to merge #10094

mattlord
mattlord approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@mattlord mattlord mentioned this pull request May 21, 2022
Closed
3 tasks
@deepthi deepthi merged commit f7c19c9 into vitessio:main May 24, 2022
@deepthi deepthi deleted the ds-cleanup-56-docker branch May 24, 2022 10:57
@mattlord mattlord mentioned this pull request May 24, 2022
Merged
3 tasks
mattlord added a commit to planetscale/vitess that referenced this pull request May 24, 2022
@mattlord
Remove MySQL 5.6 config
562427f 
This is a follow-up to vitessio#10295

Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord added a commit that referenced this pull request May 25, 2022
@mattlord
Revert super_read_only config file changes (#10366)
2cf3fb7 
* Revert super_read_only config file changes

This ended up causing various failures when that change was applied
in mysqlctl by updating its rice box (make embed_config). You can see
this in: #10094

We're instead going to schedule work to add full super_read_only
support to Vitess in: #10363

* Remove MySQL 5.6 config

This is a follow-up to #10295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @mattlord