From ae9396fe78f62b8dd73b0007aae22bcd593344e1 Mon Sep 17 00:00:00 2001 From: Sugu Sougoumarane Date: Wed, 17 Jan 2018 09:05:21 -0800 Subject: [PATCH] vtgate: fix vtgate_test The parsing of flags in vtgate_test caused it to eat all flags including the ones used by the test package. This caused tests here to ignore things like -run, etc. I tried changing the init to TestMain. That didn't help. So, I'm removing the parsing call for now until we figure out a different way to fix this. --- go/vt/vtgate/vtgate_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/go/vt/vtgate/vtgate_test.go b/go/vt/vtgate/vtgate_test.go index 00792db6c3d..02ce97077c6 100644 --- a/go/vt/vtgate/vtgate_test.go +++ b/go/vt/vtgate/vtgate_test.go @@ -18,7 +18,6 @@ package vtgate import ( "encoding/hex" - "flag" "fmt" "io" "math" @@ -55,8 +54,6 @@ var masterSession = &vtgatepb.Session{ } func init() { - flag.CommandLine.Parse([]string{}) // prevents glog "ERROR: logging before flag.Parse" - getSandbox(KsTestUnsharded).VSchema = ` { "sharded": false,