Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtgate executor: route "show create table" to the user-provided or vs… #4732

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

dweitzman
Copy link
Member

…chema-indicated keyspace

Previously the sql parser treated everything after CREATE TABLE as opaque.
This change updates the sql parser to look at the create table argument
to help direct queries to the appropriate keyspace.

@dweitzman dweitzman requested a review from sougou as a code owner March 18, 2019 21:13
@dweitzman dweitzman force-pushed the show_create branch 2 times, most recently from 7190a7e to 01958b6 Compare March 18, 2019 22:09
…chema-indicated keyspace

Previously the sql parser treated everything after `CREATE TABLE` as opaque.
This change updates the sql parser to look at the create table argument
to help direct queries to the appropriate keyspace.

Signed-off-by: David Weitzman <dweitzman@pinterest.com>
@sougou sougou merged commit 20bd2bb into vitessio:master Mar 19, 2019
@dweitzman dweitzman deleted the show_create branch June 18, 2019 17:39
mingjianliu pushed a commit to mingjianliu/vitess that referenced this pull request Jul 16, 2020
Summary:
1) Don't let one bad sequence disable sequences for other tables
vitessio#4743

2) Route "show create table" correctly
vitessio#4732

Reviewers: #vitess, hzhou, mingjianliu

Reviewed By: #vitess, mingjianliu

Subscribers: mingjianliu, jenkins

Differential Revision: https://phabricator.pinadmin.com/D382885
systay pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants