Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /debug/liveness handler for liveness checks. #4935

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented Jun 17, 2019

This is a handler typically used for server liveness checks. If the server can't execute this simple handler, it probably isn't able to do useful work for other incoming requests that actually ask the server to do something. In that case, the watchdog usually assumes the server process is stuck (deadlocked or livelocked) and restarts it.

Signed-off-by: Anthony Yeh enisoc@planetscale.com

Closes #4480.

This is a handler typically used for server liveness checks.
If the server can't execute this simple handler, it probably isn't
able to do useful work for other incoming requests that actually ask the
server to do something. In that case, the watchdog usually assumes the
server process is stuck (deadlocked or livelocked) and restarts it.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
@enisoc enisoc requested a review from sougou June 17, 2019 23:22
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enisoc enisoc merged commit ae4b458 into vitessio:master Jun 18, 2019
@enisoc enisoc deleted the liveness-handler branch June 18, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need liveness endpoints for vitess binaries
2 participants