New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the lowest cost vindex for each column if there are multiple ones #5023

Merged

sougou merged 1 commit into vitessio:master from mingjianliu:upstream

Jul 27, 2019

mingjianliu commented Jul 25, 2019

If the same column having multiple vindex, choose the one with lowest cost. Not the last one in ColumnVindex's order

mingjianliu requested a review from sougou as a code owner

July 25, 2019 22:19


          Keep the lowest cost vindex for each column if there are multiple ones

e6f2064

Signed-off-by: Mingjian Liu <mingjianliu@pinterest.com>

sougou approved these changes

View reviewed changes

Contributor

sougou left a comment

I'll merge this, but would like to know the use case for two columns needing two vindexes. Can you add an explanation?

sougou merged commit 9a6e7da into vitessio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet