vtbackup: Make initial backup idempotent again. #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for a complete backup already existing was supposed to make the initial backup idempotent, such that running it after an initial backup already exists will simply do nothing and return success. However, that property was broken when I added the check for serving tablets above the check for a complete backup. I should have kept the check for a complete backup first, because if there's already a complete backup and we're doing nothing, then it's fine that some tablets may already be serving. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
dkhenry
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for a complete backup already existing was supposed to make
the initial backup idempotent, such that running it after an initial
backup already exists will simply do nothing and return success.
However, that property was broken when I added the check for serving
tablets above the check for a complete backup. I should have kept the
check for a complete backup first, because if there's already a complete
backup and we're doing nothing, then it's fine that some tablets may
already be serving.
Signed-off-by: Anthony Yeh enisoc@planetscale.com