remove non-informative error message that is printed on every restart #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Sep 13, 2019
go/vt/mysqlctl/metadata_tables.go
Outdated
| log.Errorf("Unexpected error executing %v: %v", sql, err) | ||
| return err | ||
| } | ||
| } | ||
| } | ||
| sql := fmt.Sprintf(sqlUpdateLocalMetadataTable, dbName) | ||
| if _, err := conn.ExecuteFetch(sql, 0, false); err != nil { | ||
| log.Errorf("unexpected error executing %v: %v, continuing. Please check the data in _vt.local_metadata and take corrective action", sql, err) | ||
| log.Errorf("Unexpected error executing %v: %v, continuing. Please check the data in _vt.local_metadata and take corrective action.", sql, err) |
There was a problem hiding this comment.
I think we should just remove 'Unexpected' from these messages (including the one above).
There was a problem hiding this comment.
Done. I squashed the commits since the changes are so trivial.
|
I think this good to merge after @sougou comment is addressed |
…, cleanup error messages Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-rm-expected-errmsg
branch
from
66f2b0b
to
dafaae1
Compare
sougou
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run alter statements to add a
db_namecolumn to local_metadata and shard_metadata tables. These alters are only expected to succeed the first time, and are expected to fail on every subsequent vttablet restart.The
Expected errormessage is annoying and not helpful, hence it has been removed.Signed-off-by: deepthi deepthi@planetscale.com