From a851d7b9bad67f0a4c41fe883f26e28357d8d4f0 Mon Sep 17 00:00:00 2001 From: dleibovic Date: Mon, 7 Oct 2019 16:30:14 -0400 Subject: [PATCH] Fix invocation of deferred function for loading schema. Golang's defer's arguments are evaluated immediately. Thus the time.Since(start) was being resolved immediately, rather than at the end of function execution. Signed-off-by: dleibovic --- go/vt/vttablet/tabletserver/schema/engine.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/vt/vttablet/tabletserver/schema/engine.go b/go/vt/vttablet/tabletserver/schema/engine.go index 2afa16c8f53..633031f2ff6 100644 --- a/go/vt/vttablet/tabletserver/schema/engine.go +++ b/go/vt/vttablet/tabletserver/schema/engine.go @@ -113,7 +113,7 @@ func (se *Engine) Open() error { return nil } start := time.Now() - defer log.Infof("Time taken to load the schema: %v", time.Since(start)) + defer func() { log.Infof("Time taken to load the schema: %v", time.Since(start)) }() ctx := tabletenv.LocalContext() dbaParams := se.dbconfigs.DbaWithDB() se.conns.Open(dbaParams, dbaParams, dbaParams)