Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrepl: truncate messages to column length #5454

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Nov 24, 2019

If an error message is too long, then it won't get recorded
and no one will know what happened.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

If an error message is too long, then it won't get recorded
and no one will know what happened.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested a review from deepthi November 24, 2019 02:09
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but e2e test is failing, that needs to be resolved.

@sougou
Copy link
Contributor Author

sougou commented Nov 24, 2019

It's a problem with the test. I filed #5455

@sougou sougou merged commit 3b31583 into vitessio:master Nov 24, 2019
@sougou sougou deleted the ss-vrepl-trunc-msg branch November 24, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants