Fix treament of dual as sharded by reverting #5268 #5519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 001ec07.
This reverts commit 27b5aae. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jacques_revert5268
branch
from
5980813
to
e0b3396
Compare
|
+1 #5268 is "just" a performance optimisation, but it's broken quite a few scenarios. I'm currently working on shortcutting /cc @mpawliszyn |
|
Closing in favor of #5551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5508
I think we should fix the problem in #5268 by just implementing "SELECT 1 from dual" in vtgate.