Add are you alive example #5646
Conversation
Signed-off-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
|
@sverch @aquarapid can you review this? |
|
LGTM |
There was a problem hiding this comment.
I wrote most of this originally, so I put more weight on @aquarapid's review.
Although I do think we should change that one line and start hosting this from our public registry. Waiting for @dctrwatson to see what he thinks.
examples/are-you-alive/Makefile
Outdated
| @@ -0,0 +1,15 @@ | |||
| # We are using the "dev" project in our registry for this | |||
| NAME := "us.gcr.io/planetscale-dev/are-you-alive" | |||
There was a problem hiding this comment.
I think this should be us.gcr.io/planetscale-vitess/are-you-alive. Does that sound good to you @dctrwatson?
There was a problem hiding this comment.
If this is meant for public consumption, yes :)
There was a problem hiding this comment.
Ok, updated, but now I need to fix the build.
Signed-off-by: Shaun Verch <shaun@planetscale.com>
This wasn't added because it was gitignored. Signed-off-by: Shaun Verch <shaun@planetscale.com>
Now everything described in the README works with the new paths. Signed-off-by: Shaun Verch <shaun@planetscale.com>
sverch
force-pushed
the
j0_add_are_you_alive
branch
from
95104e3
to
0ac2441
Compare
Signed-off-by: Shaun Verch <shaun@planetscale.com>
Signed-off-by: Shaun Verch <shaun@planetscale.com>
|
@deepthi Is this good to merge? One test timed out but it looks unrelated to this change and isn't listed as required. |
examples/are-you-alive/README.md
Outdated
| What does it mean to be alive? | ||
|
|
||
| Well we don't know what it means for you, but we know what it means for our | ||
| Cloud Database! | ||
|
|
There was a problem hiding this comment.
Changing from "Cloud Database" to "Vitess Cluster".
examples/are-you-alive/README.md
Outdated
| ## Push to Registry | ||
|
|
||
| ``` | ||
| make build | ||
| make push | ||
| ``` |
There was a problem hiding this comment.
do we want to include this? most people won't have the necessary access.
There was a problem hiding this comment.
I'll add a note about access here, but I think documenting the commands makes sense.
|
|
||
| Configuration for deploying `are-you-alive` on Kubernetes. | ||
|
|
||
| Also deploys Prometheus and Alertmanager. |
There was a problem hiding this comment.
are we really deploying AlertManager? I don't see it.
There was a problem hiding this comment.
Ah, thanks for calling this one out. I'll just delete this directory.
|
Thanks @deepthi ! I think I addressed your comments. Let me know if there's anything else I should do before this is good to merge. |
sverch
force-pushed
the
j0_add_are_you_alive
branch
from
3005b0a
to
7743b34
Compare
Co-Authored-By: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Shaun Verch <shaun@planetscale.com>
Signed-off-by: Shaun Verch <shaun@planetscale.com>
sverch
force-pushed
the
j0_add_are_you_alive
branch
from
7743b34
to
86ceabe
Compare
This Pull Request aims to add an example of how to set up an are-you-alive deployment for Vitess. This is open sourced from PlanetScale's internal version of Are-You-Alive.
Signed-off-by: Lee Yi Jie Joel lee.yi.jie.joel@gmail.com