vrepl: vplayer must rollback on exit #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were code paths where vplayer had an open transaction on its dbclient connection, which got accidentally continued by the copier. This caused production issues with some users. The specific use case that was observed is: * vreplication performs catchup. * While it's in the middle of an apply, the context is canceled. * The copier has no work. * vreplication is asked to resume from the last saved position. * It replays the same statements already in the transaction. * This leads to dup key errors. This fix conservatively rolls back dbclient before exiting. The dbclient itself skips rollback if it's not in a transaction. This change leads to relieable rollbacks where needed. At the same time, there are no spurious rollbacks if we didn't start a transaction. As safety, I've added an extra rollback in the vreplicator loop just in case the underlying functions accidentally leave an incomplete transaction open. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were code paths where vplayer had an open transaction on
its dbclient connection, which got accidentally continued by
the copier. This caused production issues with some users.
The specific use case that was observed is:
This fix conservatively rolls back dbclient before exiting.
The dbclient itself skips rollback if it's not in a transaction.
This change leads to relieable rollbacks where needed. At the
same time, there are no spurious rollbacks if we didn't start
a transaction.
As safety, I've added an extra rollback in the vreplicator loop
just in case the underlying functions accidentally leave an
incomplete transaction open.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com