VReplication: End to End tests with a few related bug fixes #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Mar 20, 2020
config/init_db.sql
Outdated
| @@ -49,6 +49,9 @@ CREATE TABLE IF NOT EXISTS _vt.shard_metadata ( | |||
| CREATE USER 'vt_dba'@'localhost'; | |||
| GRANT ALL ON *.* TO 'vt_dba'@'localhost'; | |||
| GRANT GRANT OPTION ON *.* TO 'vt_dba'@'localhost'; | |||
| CREATE USER 'vt_dba'@'127.0.0.1'; | |||
There was a problem hiding this comment.
Is this change required for the tests to work?
|
Can you also verify that all your commits are signed? |
rohit-nayak-ps
force-pushed
the
rn-vrepl-work
branch
from
b06a74d
to
20161fb
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…or materialized tables handled properly. Add JSON as VDiff output Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ion logs Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-vrepl-work
branch
from
b9c1dff
to
e703c9b
Compare
…the merged ones Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
reviewed
Mar 22, 2020
config/init_db.sql
Outdated
| @@ -49,6 +49,9 @@ CREATE TABLE IF NOT EXISTS _vt.shard_metadata ( | |||
| CREATE USER 'vt_dba'@'localhost'; | |||
| GRANT ALL ON *.* TO 'vt_dba'@'localhost'; | |||
| GRANT GRANT OPTION ON *.* TO 'vt_dba'@'localhost'; | |||
| #CREATE USER 'vt_dba'@'127.0.0.1'; | |||
There was a problem hiding this comment.
Many people use this config in production. So, it's better to delete the commented out code.
There was a problem hiding this comment.
Sorry, oversight. Meant to remove the lines after testing. Fixed.
|
Also, looks like there's a new data race in unit_race test. |
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
|
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.