Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all external links in vitess to use https #6169

Merged
merged 1 commit into from
May 11, 2020
Merged

Change all external links in vitess to use https #6169

merged 1 commit into from
May 11, 2020

Conversation

teejae
Copy link
Contributor

@teejae teejae commented May 11, 2020 •
edited by harshit-gangal
Loading

Changing all external links in vitess to https, for security.

  • Includes web page UIs that may be served over HTTPS (but using non-HTTPS resources), and fail when loading under HTTPS urls.
  • Documentation links have been individually verified to work, like https://dev.mysql.com

Fixes #6170

Signed-off-by: Toliver Jue toliver@planetscale.com

Change all external links in vitess to use https
b531b27 
Signed-off-by: Toliver Jue <toliver@planetscale.com>
@teejae teejae requested a review from sougou as a code owner May 11, 2020 07:26
@harshit-gangal harshit-gangal merged commit d58f3d9 into vitessio:master May 11, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay systay approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

QueryLogz in vtgate WEB UI is non-functional when accessed over https
4 participants
@teejae @systay @harshit-gangal @deepthi