backport #6250 to 6.0 release branch #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some use cases where users needed to specify a sub-second duration. I tried changing the units of all the variables to Ms but that made everything else worse because some of the numbers were becoming non human readable. Instead, we'll use float64 values that also support whole numbers up to 53 bits. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com>
Now that we allow fractional seconds, let's use this as a standardized unit. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com>
This flag didn't previously exist, but there are users that want to fine tune this setting. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
approved these changes
Jun 16, 2020
…s to floats Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.