Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #6250 to 6.0 release branch #6320

Merged
merged 4 commits into from
Jun 16, 2020
Merged

backport #6250 to 6.0 release branch #6320

merged 4 commits into from
Jun 16, 2020

Commits on Jun 16, 2020

  1. yaml: convert Seconds to float64 

    There are some use cases where users needed to specify a sub-second
duration. I tried changing the units of all the variables to Ms
but that made everything else worse because some of the numbers
were becoming non human readable.

Instead, we'll use float64 values that also support whole numbers
up to 53 bits.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Signed-off-by: deepthi <deepthi@planetscale.com>
    @sougou @deepthi
    sougou authored and deepthi committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9a9a884 View commit details
    Browse the repository at this point in the history

  2. yaml: HeartbeatIntervalMilliseconds -> Seconds 

    Now that we allow fractional seconds, let's use this as a
standardized unit.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Signed-off-by: deepthi <deepthi@planetscale.com>
    @sougou @deepthi
    sougou authored and deepthi committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9d3b80d View commit details
    Browse the repository at this point in the history

  3. yaml: add queryserver-config-stream-pool-timeout 

    This flag didn't previously exist, but there are users that want
to fine tune this setting.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
    @sougou @deepthi
    sougou authored and deepthi committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    681c379 View commit details
    Browse the repository at this point in the history

  4. fix compilation errors caused by some timeouts being changed from int… 

    …s to floats

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    4e408d7 View commit details
    Browse the repository at this point in the history