Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode_loose_xxhash Vindex type #6549

Merged
merged 4 commits into from
Aug 23, 2020

Conversation

aquarapid
Copy link
Contributor

  • Refactor out unicode normalization functions
  • Add md5 benchmark
  • Change existing xxhash benchmark to benchmark Vindex
    function instead of underlying hash

Addresses #6457

Signed-off-by: Jacques Grove aquarapid@gmail.com

 * Refactor out unicode normalization functions
 * Add md5 benchmark
 * Change existing xxhash benchmark to benchmark Vindex
   function instead of underlying hash

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@aquarapid
Copy link
Contributor Author

For reference here are the benchmark runs:

BenchmarkMD5Hash/md5Hash,direct,bytes,n=8B-32            6178754               187 ns/op          42.71 MB/s
BenchmarkMD5Hash/md5Hash,direct,bytes,n=32B-32           6169424               191 ns/op         167.59 MB/s
BenchmarkMD5Hash/md5Hash,direct,bytes,n=64B-32           4098876               290 ns/op         221.07 MB/s
BenchmarkMD5Hash/md5Hash,direct,bytes,n=512B-32          1159005              1036 ns/op         494.44 MB/s
BenchmarkMD5Hash/md5Hash,direct,bytes,n=1KB-32            667616              1784 ns/op         560.67 MB/s
BenchmarkMD5Hash/md5Hash,direct,bytes,n=4KB-32            166500              6782 ns/op         589.81 MB/s
BenchmarkNormalizeSafe-32                                 141795              9848 ns/op
BenchmarkNormalizeShared-32                              2586418               425 ns/op
BenchmarkNormalizePooled-32                              2234502               451 ns/op
BenchmarkXXHash/xxHash,direct,bytes,n=8B-32             27336464                39.2 ns/op       203.93 MB/s
BenchmarkXXHash/xxHash,direct,bytes,n=32B-32            24836524                47.1 ns/op       679.41 MB/s
BenchmarkXXHash/xxHash,direct,bytes,n=64B-32            23306372                50.2 ns/op      1274.56 MB/s
BenchmarkXXHash/xxHash,direct,bytes,n=512B-32           12211312                96.8 ns/op      5289.02 MB/s
BenchmarkXXHash/xxHash,direct,bytes,n=1KB-32             7712202               148 ns/op        6761.02 MB/s
BenchmarkXXHash/xxHash,direct,bytes,n=4KB-32             2593194               462 ns/op        8657.97 MB/s

Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
We would need an end to end test to verify it works.

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…hash

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 372d5d0 into vitessio:master Aug 23, 2020
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants