Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reparent tests refactoring: setup/teardown for each test, reduce cut/paste, improve readability #6726

Merged
merged 5 commits into from
Sep 17, 2020
Merged

Reparent tests refactoring: setup/teardown for each test, reduce cut/paste, improve readability #6726

merged 5 commits into from
Sep 17, 2020

Commits on Sep 17, 2020

  1. Reparent test: refactored tests to setup/teardown everytime, improve … 

    …code quality and hopefully fix or isolate current flakiness

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    0e76ece View commit details
    Browse the repository at this point in the history

  2. Reparent tests: remove extra setup 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c12e632 View commit details
    Browse the repository at this point in the history

  3. address review comment 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    a1e810e View commit details
    Browse the repository at this point in the history

  4. Testing if conflict can be fixed by adding main_test.go back 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c290009 View commit details
    Browse the repository at this point in the history

  5. Delete main_test.go again 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    ebec8e4 View commit details
    Browse the repository at this point in the history