Add validations and logs to fix common issues faced during MoveTables/Reshard #6814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…complete workflows Signed-off-by: Rohit Nayak <rohit@planetscale.com>
… errors. 2 tests skipped for now. Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
changed the title
rohit-nayak-ps
changed the title
rohit-nayak-ps
changed the title
rohit-nayak-ps
requested review from
deepthi,
harshit-gangal,
sougou and
systay
as code owners
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
deepthi
reviewed
Oct 5, 2020
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
There is a check for an existing vschema, doesn't check if it is sharded. I will review that and add it when I fix a bunch of pending resharding issues. |
deepthi
reviewed
Oct 6, 2020
| @@ -145,12 +150,12 @@ func (dc *fakeDBClient) verifyQueries(t *testing.T) { | |||
| t.Helper() | |||
| for query, dbrs := range dc.queries { | |||
| if !dbrs.exhausted() { | |||
| t.Errorf("query: %v has unreturned results", query) | |||
| assert.FailNow(t, "expected query: %v did not get executed during the test", query) | |||
| } | |||
| } | |||
| for query, dbrs := range dc.queriesRE { | |||
| if !dbrs.exhausted() { | |||
There was a problem hiding this comment.
this can be rewritten as
assert.True(t, dbrs.exhausted(), "message")
but we won't hold up this PR for that.
deepthi
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow artifacts like entries in the _vt.vreplication and _vt.resharding_journal tables, if not cleaned up, after a workflow is completed can cause strange errors during subsequent workflows. DropSources clears these, but users don't always run DropSources. Added validations include:
Also
if user tries to reshard it and has only specified a csv table list to the movetables)
Signed-off-by: Rohit Nayak rohit@planetscale.com