Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VStreamer Field Event: add allowed values for set/enum #6981

Merged
merged 4 commits into from
Nov 2, 2020
Merged

VStreamer Field Event: add allowed values for set/enum #6981

merged 4 commits into from
Nov 2, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Nov 1, 2020 •
edited
Loading

Implements the VStream Field Event attribute enhancements detailed in issue: #6955

  • vdiff was failing on comparing diffs: fixed
  • lookup values for enum/set from information_schema.columns.column_type and add it to the attributes sent in the Field event by vstreamer

@rohit-nayak-ps
VStream Enum/Set: add test for set, make set comparable
1c06e4b 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VStream Enum/Set: remove set from uncomparable type test
5027986 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VStream Enum/Set: add column_type with set/enum values to FIELD event
9d9aaff 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VStream Enum/Set: cleanup, fix TestTypes
03f4417 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review November 1, 2020 13:35
@sougou sougou merged commit 53715c5 into vitessio:master Nov 2, 2020
@sougou sougou deleted the rn-vstream-enum-set-metadata branch November 2, 2020 20:22
@askdba askdba added this to the v9.0 milestone Nov 11, 2020
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Jan 28, 2021
Closed
5 tasks
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@sougou sougou sougou approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rohit-nayak-ps @sougou @shlomi-noach @askdba