Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRepl/Tablet Picker: improve observability of selected tablet #6999

Merged
merged 3 commits into from
Nov 12, 2020
Merged

VRepl/Tablet Picker: improve observability of selected tablet #6999

merged 3 commits into from
Nov 12, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Nov 5, 2020 •
edited
Loading

  • Tablet picker: surface errors and selected source tablets both in _vt.vreplication and debug vars. This can help resolve issues where vreplication is not progressing/starting and an incorrect tablet is selected or there is no tablet available for the cell/tablet_type parameters specified.

Signed-off-by: Rohit Nayak rohit@planetscale.com

@rohit-nayak-ps
Tablet picker msg: surface picked tablet or picker errors to _vt.vrep…
72d76e7 
…lication and metrics

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Reduce flakiness by removing error-prone validation
f57799f 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps changed the title Vreplication: various validation/observability related improvements VRepl/Tablet Picker: improve observability of selected tablet Nov 9, 2020
@rohit-nayak-ps
Check for errors due to canceled context
d592d99 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review November 9, 2020 19:20
deepthi
deepthi reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sougou sougou merged commit 500a487 into vitessio:master Nov 12, 2020
@sougou sougou deleted the rn-vr-misc branch November 12, 2020 00:18
@askdba askdba added this to the v9.0 milestone Nov 27, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rohit-nayak-ps @deepthi @sougou @askdba