Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace vitess:base with vitess:lite images for docker-compose services #7004

Merged
merged 6 commits into from
Nov 12, 2020
Merged

Replace vitess:base with vitess:lite images for docker-compose services #7004

merged 6 commits into from
Nov 12, 2020

Conversation

jawabuu
Copy link
Contributor

@jawabuu jawabuu commented Nov 7, 2020

This PR replaces the huge vitess: base images >2G with the vitess:lite image.
The objective is to make it quicker for someone to spin up a docker-compose example.
A secondary objective is to mirror operator design and discard the InitShardMaster introduced here by implementing orchestrator.
@sougou @shlomi-noach @deepthi

@jawabuu
Add init_db.sql
4585415 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Switch docker image from vitess:base to vitess:lite
e626b22 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
make available init_db.sql as well as VT env variables
f917980 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
rewrite to use available binaries and allowed paths in lite image
cecc976 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
fix vtctld backup_storage_root path
d01770a 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
update vtcompose to use vites:lite image
32f8376 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
shlomi-noach
shlomi-noach reviewed Nov 8, 2020
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions inline for clarifications.

examples/compose/config/init_db.sql Show resolved Hide resolved
examples/compose/config/init_db.sql Show resolved Hide resolved
sougou
sougou approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I didn't verify that this works, but the changes look good. If we encounter new problems, we can always fix forward.

examples/compose/config/init_db.sql Show resolved Hide resolved
examples/compose/schemaload.sh Show resolved Hide resolved
@sougou sougou merged commit c6da712 into vitessio:master Nov 12, 2020
@askdba askdba added this to the v9.0 milestone Nov 27, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach left review comments

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jawabuu @sougou @shlomi-noach @askdba