Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Planning and Parsing Support for Create View of MySQL 5.7 #7060

Merged
merged 19 commits into from
Dec 14, 2020
Merged

Adds Planning and Parsing Support for Create View of MySQL 5.7 #7060

merged 19 commits into from
Dec 14, 2020

Conversation

GuptaManan100
Copy link
Member

Adds Planning and Parsing Support for Create View of MySQL 5.7

@GuptaManan100
Parsing for Create View Prefix complete with definer remaining
0c492b7 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
parsing for create view complete except definer
8029eea 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as draft November 20, 2020 05:05
@GuptaManan100 GuptaManan100 added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Nov 20, 2020
@GuptaManan100
Planning for create view and added tests
4661842 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
updated tests
7e28d2f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Skipped the test for sharded keyspace since it is not supported for now
280a01d 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged Master
4947f35 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
parsing for create view complete
32278ab 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged master
b68f232 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
fixed tests
b0ce396 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 3, 2020 11:26
shlomi-noach
shlomi-noach approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻

@GuptaManan100
Merged master
222a1ab 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal reviewed Dec 7, 2020
View reviewed changes
go/vt/sqlparser/parse_test.go Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/ddl.go Outdated Show resolved Hide resolved
@GuptaManan100
cleanup
4dd555c 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into create-view
342c754 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Full parsing support for CREATE VIEW
bd2dd37 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
fixed test
5ce3b03 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into create-view
0dfc849 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Improved planning for CreateView
09c5aa5 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Added tests for create view
7519f70 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into create-view
cfe8ec6 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal reviewed Dec 11, 2020
View reviewed changes
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/ddl.go Show resolved Hide resolved
@harshit-gangal
Copy link
Member

nice work.

@GuptaManan100
refactored tests
7dbc668 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit d28e8e3 into vitessio:master Dec 14, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
@GuptaManan100 GuptaManan100 mentioned this pull request Feb 15, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@systay systay Awaiting requested review from systay

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @harshit-gangal @shlomi-noach