-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s3 server-side encryption and decryption with customer provided key #7088
Add s3 server-side encryption and decryption with customer provided key #7088
Conversation
Welcome @liortamari! Can you fix the DCO? Instructions here: https://github.com/vitessio/vitess/pull/7088/checks?check_run_id=1475698865 |
Signed-off-by: liortamary <lior.tamary@houzz.com>
@deepthi Thank you. |
Signed-off-by: liortamary <lior.tamary@houzz.com>
Signed-off-by: liortamary <lior.tamary@houzz.com>
That's great! We'll ask some people to review this who know better than I do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this to avoid adding a new tablet option, and be more consistent, by just making sse_c
a new option value for -s3_backup_server_side_encryption
? Could be something like:
-s3_backup_server_side_encryption sse_c:/path/to/key/file
Rest seems fine.
@aquarapid Thank you. |
…lled sse_c instead of different flag Signed-off-by: liortamary <lior.tamary@houzz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is purely opt-in, so existing users shouldn't notice, and the new feature looks correct to me. +1
I would like to add support for AWS S3 backup/restore using server-side encryption and decryption with customer provided key.