Add Version to Bootstrap Image #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a version to the bootstrap images. This will allow for an easier transition between bootstrap images. This field is starting at 0 and will be incremented to 1 for the change to golang 1.15 Signed-off-by: D.K <dan.kozlowski@gmail.com>
|
@aquarapid This PR doesn't change the UBI image building, but UBI's appear to not work with this change |
Must de-reference paramaters Signed-off-by: D.K <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com> Signed-off-by: D.K. <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com> Signed-off-by: D.K. <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com>
Need to build the bootstraps off a bootstrap Signed-off-by: D.K <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com>
Moving back to chromium and setting chromedriver to match the upstream chromium version in Debian Signed-off-by: D.K <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com>
Signed-off-by: D.K <dan.kozlowski@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This change adds a version to the bootstrap images. This will allow for
an easier transition between bootstrap images. This field is starting at
0 and will be incremented to 1 for the change to golang 1.15
Impacted Areas in Vitess
List general components of the application that this PR will affect: