vttablet: debug/env page to change variables in real-time #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
sougou
changed the title
rafael
approved these changes
Dec 21, 2020
| Value string | ||
| } | ||
|
|
||
| func debugEnvHandler(tsv *TabletServer, w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Probably we should reject the request if the method is not POST
There was a problem hiding this comment.
I actually rely on this for my tests, by using GET. Is there a reason to disallow? Also, we seem to be allowing it in other places.
There was a problem hiding this comment.
I saw that, If you change this, you will have to update the tests.
I think the reason is general HTTP conventions. In theory, GET requests could be cached and shouldn't mutate state.
I think that ideally, we should stop propagating this pattern. Once people start relying on the get will become even more difficult to change it.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
NO
Status
READY
Description
Feature implemented as specified in RFC.
Also added links to the new page from
/debug/statusRelated Issue(s)
Fixes #7171
Fixes #2983
Todos
Deployment Notes
None
Impacted Areas in Vitess
List general components of the application that this PR will affect: