Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL executor database pool size increase #7206

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

shlomi-noach
Copy link
Contributor

Backport

NO

Status

READY

Description

Fixing an issue raised in chat by @aquarapid, this PR:

  • Uses more explicit name for the online DDL executor database pool
  • Sets pool size to 3 rather than 1. Originally I thought all operations would necessarily be sequential, and so set max pool size to 1. Operations are not all sequential now, and in hindsight it was wrong to set to 1.

Impacted Areas in Vitess

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…or-pool

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link
Contributor

@aquarapid aquarapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlomi-noach shlomi-noach merged commit 2b128ba into vitessio:master Dec 23, 2020
@shlomi-noach shlomi-noach deleted the online-ddl-executor-pool branch December 23, 2020 06:35
@askdba askdba added this to the v9.0 milestone Dec 23, 2020
@askdba askdba changed the title Online DDL executor databae pool size increase Online DDL executor database pool size increase Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants