Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows any ordering of generic options in column definitions #7459

Merged
merged 7 commits into from
Feb 10, 2021

Conversation

GuptaManan100
Copy link
Member

Allows any ordering of generic options in column definitions

FIxes #7378 #7455

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M T G L

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@harshit-gangal
Copy link
Member

needs conflict resolution.

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed. Looks good.

go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@systay systay merged commit 43cb3fb into vitessio:master Feb 10, 2021
@systay systay deleted the alter-table-not-null branch February 10, 2021 05:01
@askdba askdba added this to the v10.0 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing error/warning caused by AUTO_INCREMENT after PRIMARY KEY on a column
6 participants