Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Show plan from executor to planbuilder #7475

Merged
merged 15 commits into from
Feb 21, 2021
Merged

Moving Show plan from executor to planbuilder #7475

merged 15 commits into from
Feb 21, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 9, 2021 •
edited
Loading

Description

This is to support show queries view plan builder and along the way add support for queries that does not work.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@harshit-gangal
added dbanem in ShowBasic ast and moved few of the show commands from…
2348d69 
… legacy to ShowBasic

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added show plan for show commands with dbname
ec552f9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
use showBasic instead of showLegacy in tabletserver planner
1e3b879 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
use full_opt instead of command
f44af7a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added support for from table in showBasic
2fbb74c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
plan indexes and columns in show
34e683f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
parse show create queries
f513d35 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix table parsing for VSchema generation to include reserved and non …
d1fb707 
…reserved keywords

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix user keyword test in executor test
c23bf6a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix user keyword test in vtexplain test
cf9a8b6 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix user keyword in planbuilder tests
0b4a905 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
moved show create plans from executor to planbuilder
9674e9f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix vttablet test
1340188 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added plan for show create statements and rewrite the dbname
42d62b9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review February 16, 2021 13:06
@harshit-gangal
added more show plans and fixed the show planbuilder
742c5f9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@harshit-gangal harshit-gangal merged commit 0dbe96e into vitessio:master Feb 21, 2021
@harshit-gangal harshit-gangal deleted the show-plan branch February 21, 2021 19:10
@askdba askdba added this to the v10.0 milestone Feb 22, 2021
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Show tables fails on system tables.
4 participants
@harshit-gangal @systay @GuptaManan100 @askdba