Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoveTables: Refresh SrvVSchema (for Routing Rules) and source tablets (for Blacklisted Tables) on completion #7505

Merged
merged 4 commits into from
Feb 19, 2021
Merged

MoveTables: Refresh SrvVSchema (for Routing Rules) and source tablets (for Blacklisted Tables) on completion #7505

merged 4 commits into from
Feb 19, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Feb 17, 2021 •
edited
Loading

Description

This PR fixes two refresh problems during vreplication workflows:

  • SrvVSchema was not being rebuilt after DropSources resulting in existing routing rules still being visible to vtgate since vttablets still saw the old rules. This PR updates the SrvVSchema when routing rules are modify.
  • When blacklisted tables are updated only the current primary tablet was being refreshed. However this causes a problem if there is a reparenting operation. This PR now refreshes all tablets in the shard.

Related Issue(s)

#7477

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@rohit-nayak-ps rohit-nayak-ps force-pushed the rn-movetables-refresh-routing-rules branch from 8145732 to 64370c2 Compare February 17, 2021 11:22
@rohit-nayak-ps
Rebuild SrvVSchema after deleting routing rules on MoveTables complet…
953a092 
…ion/cancellation

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Check that routing rules are deleted in unit test
f15e388 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Fix typo
f22119e 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps force-pushed the rn-movetables-refresh-routing-rules branch from 554ba4a to f22119e Compare February 17, 2021 13:00
@rohit-nayak-ps
Refresh all tablets in a shard when updating blacklisted tables
275e4c8 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review February 18, 2021 13:07
deepthi
deepthi approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-nayak-ps rohit-nayak-ps merged commit 83b7408 into vitessio:master Feb 19, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-movetables-refresh-routing-rules branch February 19, 2021 08:35
@askdba askdba added this to the v10.0 milestone Feb 22, 2021
@aquarapid
Copy link
Contributor

@rohit-nayak-ps does this resolve #7477 , or is there more to do?

@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Feb 28, 2021
Closed
@systay systay mentioned this pull request May 6, 2021
Merged
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
@mattlord mattlord mentioned this pull request Apr 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Query Serving Component: VReplication
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rohit-nayak-ps @aquarapid @deepthi @askdba