Add innodb_read_rows as vttablet metric #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
force-pushed
the
more-metrics
branch
2 times, most recently
from
f33a58d
to
b44187e
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added
Component: Query Serving
Type: Enhancement
deepthi
reviewed
Feb 20, 2021
| @@ -99,6 +100,7 @@ func NewEngine(env tabletenv.Env) *Engine { | |||
| _ = env.Exporter().NewGaugeDurationFunc("SchemaReloadTime", "vttablet keeps table schemas in its own memory and periodically refreshes it from MySQL. This config controls the reload time.", se.ticks.Interval) | |||
| se.tableFileSizeGauge = env.Exporter().NewGaugesWithSingleLabel("TableFileSize", "tracks table file size", "Table") | |||
| se.tableAllocatedSizeGauge = env.Exporter().NewGaugesWithSingleLabel("TableAllocatedSize", "tracks table allocated size", "Table") | |||
| se.innoDbReadRowsGauge = env.Exporter().NewGaugesWithSingleLabel("InnodbRowsRead", "number of rows read by mysql", "Database") | |||
There was a problem hiding this comment.
Why do we need a label? Why can't we simply use NewGauge?
Comment on lines
402
to
409
| if len(readRowsData.Rows) == 1 && len(readRowsData.Rows[0]) == 2 { | ||
| value, err := evalengine.ToInt64(readRowsData.Rows[0][1]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| se.innoDbReadRowsGauge.Set("read_rows", value) | ||
| } |
There was a problem hiding this comment.
we should log a message or return an error if the condition is not met.
Signed-off-by: Andres Taylor <andres@planetscale.com>
shlomi-noach
approved these changes
Feb 22, 2021
harshit-gangal
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to track how much work the underlying storage has had to do, not just see how much output there's been.
Related Issue: #7372