-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce query warnings for using features not supported when sharded #7538
Merged
harshit-gangal
merged 11 commits into
vitessio:master
from
planetscale:sharded-warnings
Mar 22, 2021
Merged
Produce query warnings for using features not supported when sharded #7538
harshit-gangal
merged 11 commits into
vitessio:master
from
planetscale:sharded-warnings
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
changed the title
Log warnings for queries unsupported in a sharded keyspace
Produce query warnings for using features not supported when sharded
Mar 9, 2021
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
sharded-warnings
branch
from
March 10, 2021 07:54
525a29f
to
ae21865
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Mar 18, 2021
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user is using Vitess in unsharded mode, but they know that they will need to shard to scale, enabling this feature will start producing query warnings when a feature is used that is not supported in sharded mode.
By adding the flag
-warn_sharded_only=true
to the vtgate start parameters, warnings will be produced for these features.Example:
Checklist
Impacted Areas in Vitess
Components that this PR will affect: