Reset Session for Reserved Connection when the connection id is not found #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e session Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
approved these changes
Feb 23, 2021
1 task
|
💯 for writing 50 lines of tests for a 1-line fix 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When is connection is marked as reserved and not in transaction. If the connection remains ideal for 30 secs (default). It is killed in vttablet, but the VTGate session does not clear this information.
When the user hits a query on the same session, if the error returned from vttablet is
transaction x ended at ...then VTGate handles this error and recreate the connection with the right properties.But if it received
transaction x not foundthen it is not handled and the session is not usable.The current change handles this scenario as well.
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: